Skip to content

Pin mike at version 0.5.1 #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2020
Merged

Pin mike at version 0.5.1 #729

merged 1 commit into from
May 29, 2020

Conversation

masci
Copy link
Contributor

@masci masci commented May 28, 2020

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • The PR follows our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?

It pins mike version at 0.5.1 in the requirements file

  • What is the current behavior?

mike version is not pinned and it gets the latest at each docs build. We're having a problem with latest version 0.5.2 as seen here https://github.com/arduino/arduino-cli/runs/716092672#step:11:103

  • What is the new behavior?

While we investigate why 0.5.2 fails, pin 0.5.1 that was proven to work

  • Does this PR introduce a breaking change?

No CLI changes


See how to contribute

@rsora rsora merged commit ae41268 into master May 29, 2020
@rsora rsora deleted the massi/pin-mike branch May 29, 2020 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants